xurror opened a new pull request #716: FINERACT-696 URL: https://github.com/apache/fineract/pull/716 add spotbug bug-pattern plugin. closes https://issues.apache.org/jira/browse/FINERACT-696 ## Description While code reviewing https://github.com/apache/fineract/pull/464, I came accross a catch & printStackTrace, which is of course wrong (it should instead be, correctly, logged, instead). In an ideal world, it would not take human code review to catch this, but just an automated build failure. This is possible using SpotBugs (not FindBugs anymore; SpotBugs is the new FindBugs, it's a fully compatible successor) and https://github.com/KengoTODA/findbugs-slf4j/ (for this particular case https://github.com/KengoTODA/findbugs-slf4j/issues/70, but using findbugs-slf4j for Fineract would have value even before that's implemented). ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API. - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. - [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes. - [ ] Integration tests have been created/updated for verifying the changes made. - [ ] All Integrations tests are passing with the new commits. - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.) Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
