vorburger commented on a change in pull request #715: FINERACT-823 Gradle
modernizer plugin
URL: https://github.com/apache/fineract/pull/715#discussion_r389364312
##########
File path: fineract-provider/build.gradle
##########
@@ -298,6 +300,22 @@ if (project.hasProperty('security') &&
project.getProperty('security') == 'oauth
}
}
+modernizer {
+ includeTestClasses = false
+ failOnViolations = false
+
+ violationLogLevel="warn"
Review comment:
Thanks for this contribution, I love it! Seeing that this only adds
additional warn logs during the build, I fear everyone will just ignore this,
and it won't really add any value... (This is why Checkstyle and SpotBugs are
"enforced" now; if we don't do that, it's pretty much pointless.) I think what
would be much more useful is if this was set to fail on violation, at violation
log level error. I suspect that probably will cause some failure, but we should
fix those...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
