vorburger commented on a change in pull request #734: SonarQube is add to do 
the analysis of Fineract code
URL: https://github.com/apache/fineract/pull/734#discussion_r392659231
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -61,5 +61,5 @@ script:
 # using "&&" instead of several "-" means that integrationTest does not run if 
test fails,
 # and Docker test does not run if integration test fails, which makes PR 
failure easier to understand.
 # @see 
https://docs.travis-ci.com/user/job-lifecycle/#customizing-the-build-phase
-  - ./gradlew --console=plain licenseMain licenseTest licenseIntegrationTest 
check  &&  ./gradlew --console=plain integrationTest  &&  sudo service mysql 
stop  &&  docker-compose build  &&  docker-compose up -d  &&  sleep 30s  &&  
http --verify=no --timeout 240 --check-status get 
https://localhost:8443/fineract-provider/actuator/health
+  - ./gradlew --console=plain licenseMain licenseTest licenseIntegrationTest 
check  && ./gradlew --console=plain integrationTest && ./gradlew 
--console=plain sonarqube -Dsonar.host.url=$SONAR_HOST_URL 
-Dsonar.organization=$SONAR_ORGANIZATION -Dsonar.projectKey=$SONAR_PROJECT_KEY 
-Dsonar.login=$SONAR_TOKEN -Dsonar.verbose=true --stacktrace &&  sudo service 
mysql stop  &&  docker-compose build  &&  docker-compose up -d  &&  sleep 30s  
&&  http --verify=no --timeout 240 --check-status get 
https://localhost:8443/fineract-provider/actuator/health
 
 Review comment:
   Where/how is SONAR_TOKEN etc. defined?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to