anubhav11march commented on a change in pull request #95: fix: Added network 
change register
URL: https://github.com/apache/fineract-cn-mobile/pull/95#discussion_r396116696
 
 

 ##########
 File path: 
app/src/main/java/org/apache/fineract/ui/online/DashboardActivity.java
 ##########
 @@ -74,6 +76,8 @@ protected void onCreate(Bundle savedInstanceState) {
             StartSyncJob.scheduleItNow();
             preferencesHelper.setFetching(false);
         }
+
+        registerNetworkRegister();
 
 Review comment:
   Actually, if we do not register it in code, then it will be registered 
everywhere in the app. And even for that, we would need to create a separate 
process to handle the receiver. We only need it work when the user has logged 
in.
   Also, this is the best and most non expensive way to implement this. I have 
thoroughly tested it and it is working as intended.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to