xurror commented on a change in pull request #749: Fineract 853
URL: https://github.com/apache/fineract/pull/749#discussion_r401531382
 
 

 ##########
 File path: fineract-provider/dependencies.gradle
 ##########
 @@ -26,6 +26,14 @@ dependencies {
     providedRuntime("org.springframework.boot:spring-boot-starter-tomcat")
     
     spotbugsPlugins "jp.skypencil.findbugs.slf4j:bug-pattern:1.4.2@jar"
 
 Review comment:
   Since this the second plugin, it is preferable to change the implementation 
like this so that other comments can just be appended to the end.
   That way the code looks better, if you get what I'm saying.
   
   ```suggestion
       spotbugsPlugins (
                      "jp.skypencil.findbugs.slf4j:bug-pattern:1.4.2@jar",
                      "com.h3xstream.findsecbugs:findsecbugs-plugin:1.8.0"
       )
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to