ptuomola opened a new pull request #807:
URL: https://github.com/apache/fineract/pull/807


   ## Description
   Fixed bootRun / bootJar by: 
   - Rewriting ServerApplication class based on SpringBoot documentation
   - Fixing SSL configuration for Tomcat by removing trust store config
   - Reworking dependencies to remove conflicts (conflicting HikariCP, missing 
commons-logging and commons-io, 
   
   To avoid conflict between embedded Tomcat and Spring Boot Tomcat:
   - Added Cargo plugin for Gradle to start a separate Tomcat instance
   - Changed integrationTest to use separate Tomcat instance through Cargo 
plugin
   - Removed embedded Tomcat and Gradle Tomcat plugin
   
   Fixed failing integration tests by adding a delay after a job has been 
scheduled to allow time for the job to get registered / start
   
   TODO:
   - Get the dev profile (using MariaDB4j) to work in the same way with 
integrationTest etc
   - Update Confluence pages to remove references to tomcatRunWar etc
   
   And apologies for the messed up commit history - hope the pull request is OK 
though! 
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [X] Commit message starts with the issue number from 
https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [X] Coding conventions at 
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have 
been followed.
   
   - [X] API documentation at 
https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been 
updated with details of any API changes.
   
   - [X] Integration tests have been created/updated for verifying the changes 
made.
   
   - [X] All Integrations tests are passing with the new commits.
   
   - [X] Submission is not a "code dump".  (Large changes can be made "in 
repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at 
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to