awasum commented on a change in pull request #807:
URL: https://github.com/apache/fineract/pull/807#discussion_r419125404



##########
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/SchedulerJobHelper.java
##########
@@ -115,6 +115,9 @@ public void executeJob(String jobName) throws 
InterruptedException {
 
                 // Executing Scheduler Job
                 runSchedulerJob(this.requestSpec, jobId.toString());
+                
+                // Need to give the job an opportunity to start - otherwise 
below might return false as job not yet started
+                Thread.sleep(15000);

Review comment:
       @ptuomola, I am looking into it but I cannot seem to replicate the issue 
locally as when running ```./gradlew integrationTest --tests 
ClientSavingsIntegrationTest ``` 
   Everything passes locally. Could it be that our Travis Vm is not powerful 
enough?
   If you have time to get this done earlier than me. Do it.
   
   My fix for FINERACT-855 involved doing something like this where we are 
accessing the jobHistoryData...like so:
   
   ``` Assert.assertEquals("Verifying Last Scheduler Job Status", "success",
                           jobHistoryData.get(jobHistoryData.size() == 0 ? 
jobHistoryData.size() : jobHistoryData.size() - 1).get("status"));``` 
   
   So that we stop getting the ArrayOutOfBounceException.
   
   That may not be a good solution.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to