vorburger commented on a change in pull request #807:
URL: https://github.com/apache/fineract/pull/807#discussion_r419128267
##########
File path:
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/SchedulerJobHelper.java
##########
@@ -115,6 +115,9 @@ public void executeJob(String jobName) throws
InterruptedException {
// Executing Scheduler Job
runSchedulerJob(this.requestSpec, jobId.toString());
+
+ // Need to give the job an opportunity to start - otherwise
below might return false as job not yet started
+ Thread.sleep(15000);
Review comment:
My suggestion would be that we wrap up this PR ASAP by strictly and
naively :imp: following the process outlined on
https://github.com/apache/fineract#pull-requests ... @ptuomola just try to get
this PR to fully pass the build by raising separate PRs, and then rebasing, for
any tests that fail on you here. The "full" (proper) solution, whether
`Thread.sleep(15000)` or something else, should IMHO be worked on completely
separate from this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
