xurror commented on a change in pull request #820:
URL: https://github.com/apache/fineract/pull/820#discussion_r421235125
##########
File path: fineract-provider/dependencies.gradle
##########
@@ -80,9 +80,10 @@ dependencies {
'org.drizzle.jdbc:drizzle-jdbc',
- 'org.apache.poi:poi',
- 'org.apache.poi:poi-ooxml',
- 'org.apache.poi:poi-ooxml-schemas',
+ 'org.apache.poi:poi:4.1.2',
Review comment:
Since https://github.com/apache/fineract/pull/662, we don't want to set
version numbers for prject dependencies in dependencies.gradle but in the
build.gradle.
Version numbers don't really fit here anymore. Look at
https://github.com/apache/fineract/pull/662 for more about this.
##########
File path: fineract-provider/build.gradle
##########
@@ -21,6 +21,9 @@ Run as:
gradle clean bootRun'''
project.ext.jerseyVersion = '1.19.4'
+ext["rest-assured.version"] = '4.3.0'
Review comment:
Also, I don't think this will be necessary since you can just define the
dependency as is done https://github.com/apache/fineract/pull/662
##########
File path: fineract-provider/dependencies.gradle
##########
@@ -80,9 +80,10 @@ dependencies {
'org.drizzle.jdbc:drizzle-jdbc',
- 'org.apache.poi:poi',
- 'org.apache.poi:poi-ooxml',
- 'org.apache.poi:poi-ooxml-schemas',
+ 'org.apache.poi:poi:4.1.2',
+ 'org.apache.poi:poi-ooxml:4.1.2',
Review comment:
I also noticed some of these dependencies were already defined in
build.gradle though just older, so you could just go and update the version
numbers there. Is that OK with you??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
