vorburger commented on a change in pull request #857: URL: https://github.com/apache/fineract/pull/857#discussion_r422526764
########## File path: Dockerfile ########## @@ -49,13 +49,5 @@ COPY ./docker/server.xml /opt/bitnami/tomcat/conf RUN chmod 664 /opt/bitnami/tomcat/conf/server.xml WORKDIR /opt/bitnami/tomcat/lib -# org.drizzle.jdbc.DrizzleDriver is used by default for both the all tenants and demo tenant DB DataSource -RUN wget https://repo1.maven.org/maven2/org/drizzle/jdbc/drizzle-jdbc/1.4/drizzle-jdbc-1.4.jar Review comment: this is required, both because it's the current default, and because it is part of Fineract - we can't have it as a dependency in Gradle, but then not have it in the Dockerfile... because the container image that is built by this Dockerfile is distributed by the ASF, I'm assuming we're still bound by LEGAL-462. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
