This is an automated email from the ASF dual-hosted git repository.
awasum pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new dec9d21 add First Interaction Greeting GitHub Action (#880)
dec9d21 is described below
commit dec9d21f718da548ea4ee1e79fa3f872e6565ea9
Author: Michael Vorburger ⛑️ <[email protected]>
AuthorDate: Mon May 11 13:09:57 2020 +0200
add First Interaction Greeting GitHub Action (#880)
---
.github/workflows/first-interaction.yml | 13 +++++++++++++
README.md | 4 +++-
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/first-interaction.yml
b/.github/workflows/first-interaction.yml
new file mode 100644
index 0000000..a297299
--- /dev/null
+++ b/.github/workflows/first-interaction.yml
@@ -0,0 +1,13 @@
+name: Greetings
+
+on: [pull_request, issues]
+
+jobs:
+ greeting:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/first-interaction@v1
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+ # issue-message: 'Message that will be displayed on users'' first
issue'
+ pr-message: 'Welcome to Apache Fineract!! Have you read
https://github.com/apache/fineract/#pull-requests? Already subscribed to our
mailing list by sending an (empty) email to [email protected]?
Created your JIRA account on https://issues.apache.org/jira/projects/FINERACT/?
Played with our server at https://www.fineract.dev? We're very excited to
have you onboard contributing.'
diff --git a/README.md b/README.md
index de1c4e5..bdffaf0 100644
--- a/README.md
+++ b/README.md
@@ -274,7 +274,7 @@ Pull Requests
If your PR is failing to pass our CI build due to a test failure, then:
1. Understand if the failure is due to your PR or an unrelated unstable test.
-1. If you suspect it is because of a "flaky" test, and not due to a change in
your PR, then please do not simply wait for an active maintainer to come and
help you, but instead be a proactive contributor to the project - see next
steps.
+1. If you suspect it is because of a "flaky" test, and not due to a change in
your PR, then please do not simply wait for an active maintainer to come and
help you, but instead be a proactive contributor to the project - see next
steps. Do understand that we may not review PRs that are not green - it is the
contributor's (that's you!) responsability to get a proposed PR to pass the
build, not primarily the maintainers.
1. Search for the name of the failed test on https://issues.apache.org/jira/,
e.g. for `AccountingScenarioIntegrationTest` you would find
[FINERACT-899](https://issues.apache.org/jira/browse/FINERACT-899).
1. If you happen to read in such bugs that tests were just recently fixed, or
ignored, then rebase your PR to pick up that change.
1. If you find previous comments "proving" that the same test has arbitrarily
failed in at least 3 past PRs, then please do yourself raise a small separate
new PR proposing to add an `@Ignore // TODO FINERACT-123` to the respective
unstable test (e.g. [#774](https://github.com/apache/fineract/pull/774)) with
the commit message mentioning said JIRA, as always. (Please do NOT just
`@Ignore` any existing tests mixed in as part of your larger PR.)
@@ -289,6 +289,8 @@ Guideline for new Feature commits involving Refactoring: If
you are submitting P
and it involves refactoring, try to differentiate "new Feature code" with
"Refactored" by placing
them in different commits. This helps review to review your code faster.
+We have an automated Bot which marks pull requests as "stale" after a while,
and ultimately automatically closes them.
+
Releasing
---------
