Wandji69 commented on pull request #883: URL: https://github.com/apache/fineract/pull/883#issuecomment-626680791
> You have uncommented the checkstyle modules, I think we need to uncomment them one by one, and enforce them so that the build wont fail. > Also, I suggest not adding new modules and currently focus on what were already decided by @vorburger > > What do you suggest? I Understand that, but the modules suggested by @vorburger are from https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml and while I was going through the checksytle docs I saw a usage example that meets the google coding conventions here https://github.com/checkstyle/checkstyle/blob/56307daaf4921243c16a874b844757961618003b/src/main/resources/google_checks.xml. I have just removed something's not need and added what was missing in some places ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
