vorburger commented on pull request #894: URL: https://github.com/apache/fineract/pull/894#issuecomment-629647214
> @vorburger, @ptuomola @awasum, is this OK for you? Looks like it builds! But I don't know if that Batch ResolutionHelper class has any test coverage... perhaps you could have a quick look using https://github.com/apache/fineract#code-coverage-reports if it those? If the lines you're changing here is covered by tests, then I'm OK to merge this. If not, perhaps someone should review that `JsonModel` => `JsonPath` + `ReadContext` business a little more closely... anyone reading this interested in having a closer look and doing a real code review? PS: It would be neat if somehow automatically code coverage would show in PRs... anyone got an idea? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
