vorburger commented on pull request #907:
URL: https://github.com/apache/fineract/pull/907#issuecomment-632108963


   > I had rebased before pushing up modifications and #913 in showing in the 
code. 
   
   Ok, great.
   
   > Does it matter if I running on Java 11?
   
   Fineract does not support Java 8 anymore, only Java 11.
   
   > When I ran locally ./gradlew build -- showing same error.
   
   yeah, I just locally pulled this PR, and likewise, I could locally reproduce 
it as well. Looking into `build/reports/spotbugs/main.html`, we can see that 
SpotBugs actually picked up on a real subtle but important bug breaking 
functionality that we would have introduced had we merged this PR as it is 
currently - thank God for SpotBugs! @nnatarajan will you look into and fix that 
particular problem here to get this PR to be green.
   
   FINERACT-989 will look into the more general issue (not directly related to 
this PR) of SpotBug reporting.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to