maektwain opened a new pull request #925:
URL: https://github.com/apache/fineract/pull/925


   While debugging, the previous code was returning null even with data. Tested 
on the current fineract.dev (does not work)
   findProductIdAndProductTypeAndFinancialAccountTypeAndChargeId
   
   ## Description
   When you make a savings product with charges and associate them with 
accounting using advanced accounting rules you can map them to INCOME and FEES 
based operating headers.
   
   Once any transaction associated to this charges will be diverted in those 
account headers properly.
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [ ] Commit message starts with the issue number from 
https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at 
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have 
been followed.
   
   - [ ] API documentation at 
fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been 
updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes 
made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in 
repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at 
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to