vorburger commented on a change in pull request #924:
URL: https://github.com/apache/fineract/pull/924#discussion_r429377378



##########
File path: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java
##########
@@ -171,6 +172,12 @@ public AccountSummaryCollectionData 
retrieveGroupAccountDetails(final Long group
         return this.jdbcTemplate.query(sql, rm, new Object[]{groupId , 
glimAccount});
     }
 
+    @Override
+    public Collection<LoanAccountSummaryData> 
retrieveGroupActiveLoanAccountSummary(final Long groupId) {
+        final String loanWhereClause = " where l.group_id = ? and 
l.loan_status_id = 300 ";

Review comment:
       This still doesn't seem to take the code review feedback that 
@vishwasbabu had provided in #574 into account?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to