vorburger commented on a change in pull request #926:
URL: https://github.com/apache/fineract/pull/926#discussion_r429613205
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AbstractLoanScheduleGenerator.java
##########
@@ -517,9 +517,11 @@ private LoanScheduleModelPeriod
handleRecalculationForTransactions(final MathCon
scheduleParams.getTotalCumulativePrincipal().plus(
currentPeriodParams.getPrincipalForThisPeriod().minus(principalProcessed)),
scheduleParams.getPeriodNumber() + 1, mc));
- if
(loanApplicationTerms.getAmortizationMethod().isEqualInstallment()
- &&
fixedEmiAmount.compareTo(loanApplicationTerms.getFixedEmiAmount()) != 0) {
- currentPeriodParams.setEmiAmountChanged(true);
+ if
(loanApplicationTerms.getAmortizationMethod().isEqualInstallment())
+ if(fixedEmiAmount != null) {
+ if
(fixedEmiAmount.compareTo(loanApplicationTerms.getFixedEmiAmount()) != 0) {
Review comment:
why did you use the && style below as discussed, but kept if/if/if style
here? This is inconsistent, please change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
