percyashu commented on a change in pull request #830:
URL: https://github.com/apache/fineract/pull/830#discussion_r431971357
##########
File path: fineract-provider/build.gradle
##########
@@ -278,6 +280,88 @@ configurations {
tasks.withType(JavaCompile) {
options.compilerArgs += ["-Xlint:unchecked","-Xlint:cast","-Werror"] //
TODO FINERACT-959 (gradually) enable -Xlint:all (see "javac -help -X")
options.deprecation = true
+ options.errorprone {
+ disableWarningsInGeneratedCode = true
+ //Todo Remove necessary checks from this list
+ disable("UnusedVariable",
+ "VariableNameSameAsType",
+ "InconsistentCapitalization",
+ "UnnecessaryParentheses",
+ "ClassCanBeStatic",
+ "MissingCasesInEnumSwitch",
+ "CompareToZero",
+ "OperatorPrecedence",
+ "MixedMutabilityReturnType",
+ "SameNameButDifferent",
+ "EqualsGetClass",
+ "ReferenceEquality",
+ "StringSplitter",
+ "MissingOverride",
+ "BigDecimalEquals",
+ "ImmutableEnumChecker",
+ "EqualsUnsafeCast",
+ "AssertEqualsArgumentOrderChecker",
+ "BoxedPrimitiveEquality",
+ "BadImport",
+ "UnusedMethod",
+ "ModifiedButNotUsed",
+ "ArgumentSelectionDefectChecker",
+ "JodaPlusMinusLong",
+ "TypeParameterUnusedInFormals",
+ "DoubleBraceInitialization",
+ "UnusedNestedClass",
+ "UndefinedEquals",
+ "JdkObsolete",
+ "OperatorPrecedence",
+ "NarrowingCompoundAssignment"
+ )
+ //TODO gradually enable these checks
+ error( "DefaultCharset",
Review comment:
Yeah
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
