vorburger commented on pull request #923: URL: https://github.com/apache/fineract/pull/923#issuecomment-637797517
> I intentionally stopped on this one, since number of file changes would be more than 300 in this case. If so, merge conflicts will probably be too many to solve manually. Was it a bad idea to stop this, did I get anything wrong? No, you're actually absolutely right, and raising a good point here. Hm, I'm not sure, how should we best do this? You suggested gradually, in a serious of several smaller PRs, right? So I guess what you could do is just remove actually already adding the `<module name="ConstantName" />` to `fineract-provider/config/checkstyle/checkstyle.xml` here (because it's not fully complete yet, right?), and rebase and un-draft this, and I'll merge it pronto (tomorrow), if it builds of course, and then you can keep doing that? Then when only you are fully done, you raise a last PR for this which actually enforces `ConstantName`. @xurror @awasum could also help to promptly merge (only) these kinds of PRs. Sounds like a plan? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
