thesmallstar opened a new pull request #985: URL: https://github.com/apache/fineract/pull/985
This is more for discussion currently: So checkstyle believe a constant is a variable that is both "static" and "final" definitely true, but it a little big arguable do we really also need a static keyword to call it constant? MemberName check style would want something like: final int TOTAL_SUM to be changed to final int totalSum That is name final variables not like constantNames. Fineract extensively uses TOTAL_SUM way of naming things for final variables. What should we follow? @vorburger @awasum @xurror ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
