vorburger commented on a change in pull request #983:
URL: https://github.com/apache/fineract/pull/983#discussion_r436361965



##########
File path: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java
##########
@@ -200,6 +199,7 @@ public static SavingsAccountTransactionEnumData 
transactionType(final SavingsAcc
                 optionData = new 
SavingsAccountTransactionEnumData(SavingsAccountTransactionType.AMOUNT_RELEASE.getValue().longValue(),
                         
SavingsAccountTransactionType.AMOUNT_RELEASE.getCode(), "Release Amount");
                 break;
+            default:

Review comment:
       @percyashu @awasum I disagree with this, this seems wrong to me - I've 
raised new #997 for it.
   
   PS: I'm happy to help code review such PRs, if you would like me to.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to