vorburger commented on a change in pull request #1003:
URL: https://github.com/apache/fineract/pull/1003#discussion_r436460725
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/reportmailingjob/service/ReportMailingJobWritePlatformServiceImpl.java
##########
@@ -351,7 +352,7 @@ private DateTime createNextRecurringDateTime(final String
recurrencePattern, fin
// the recurrence pattern/rule cannot be empty
if (StringUtils.isNotBlank(recurrencePattern) && startDateTime !=
null) {
- final LocalDate nextDayLocalDate =
startDateTime.plus(1).toLocalDate();
+ final LocalDate nextDayLocalDate =
startDateTime.plus(Duration.millis(1)).toLocalDate();
Review comment:
This looks suspicious/wrong.. if the variable is called next DAY, why
add ONLY 1ms to Start?
@ptuomola wanna help to code review this change for correctness?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
