jawidMuhammadi commented on a change in pull request #96:
URL: https://github.com/apache/fineract-cn-mobile/pull/96#discussion_r437152594
##########
File path: app/src/main/AndroidManifest.xml
##########
@@ -93,6 +93,13 @@
<action android:name="org.apache.fineract.JobsReceiver" />
</intent-filter>
</receiver>
+
+ <receiver android:name=".utils.NetworkChangeReceiver">
+ <intent-filter>
+ <action android:name="android.net.conn.CONNECTIVITY_CHANGE" />
+ </intent-filter>
+ </receiver>
+
Review comment:
These lines of code are redundant. There is no need to register
broadcaster receive in manifest if we are doing it dynamically within the
activity. Please take a look at this
[PR](https://github.com/openMF/mifos-mobile/pull/1494/commits/5c6430883c28a9074a78b42c08a5b2f01fea59c4)
of Shiwangi Singg (GSoC student), she has done similar work.
##########
File path: app/src/main/AndroidManifest.xml
##########
@@ -93,6 +93,13 @@
<action android:name="org.apache.fineract.JobsReceiver" />
</intent-filter>
</receiver>
+
+ <receiver android:name=".utils.NetworkChangeReceiver">
+ <intent-filter>
+ <action android:name="android.net.conn.CONNECTIVITY_CHANGE" />
+ </intent-filter>
+ </receiver>
+
Review comment:
These lines of code are redundant. There is no need to register
broadcaster receiver in manifest if we are doing it dynamically within the
activity. Please take a look at this
[PR](https://github.com/openMF/mifos-mobile/pull/1494/commits/5c6430883c28a9074a78b42c08a5b2f01fea59c4)
of Shiwangi Singg (GSoC student), she has done similar work.
##########
File path: app/src/main/AndroidManifest.xml
##########
@@ -93,6 +93,13 @@
<action android:name="org.apache.fineract.JobsReceiver" />
</intent-filter>
</receiver>
+
+ <receiver android:name=".utils.NetworkChangeReceiver">
+ <intent-filter>
+ <action android:name="android.net.conn.CONNECTIVITY_CHANGE" />
+ </intent-filter>
+ </receiver>
+
Review comment:
These lines of code are redundant. There is no need to register a
broadcaster receiver in the `manifest file` if we are doing it dynamically
within the activity. Please take a look at this
[PR](https://github.com/openMF/mifos-mobile/pull/1494/commits/5c6430883c28a9074a78b42c08a5b2f01fea59c4)
of Shiwangi Singg (GSoC student), she has done similar work.
##########
File path: app/src/main/AndroidManifest.xml
##########
@@ -93,6 +93,13 @@
<action android:name="org.apache.fineract.JobsReceiver" />
</intent-filter>
</receiver>
+
+ <receiver android:name=".utils.NetworkChangeReceiver">
+ <intent-filter>
+ <action android:name="android.net.conn.CONNECTIVITY_CHANGE" />
+ </intent-filter>
+ </receiver>
+
Review comment:
These lines of code are redundant. There is no need to register a
broadcaster receiver in the `manifest file` if we are doing it dynamically
within the activity. Please take a look at this
[PR](https://github.com/openMF/mifos-mobile/pull/1494/commits/5c6430883c28a9074a78b42c08a5b2f01fea59c4)
of Shiwangi Singh (GSoC student), she has done similar work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
