thesmallstar commented on pull request #916: URL: https://github.com/apache/fineract/pull/916#issuecomment-641917539
Update: 1. I have gone through all the empty catch in detail, I found no catch block that was suspicious, in most of the cases they were left empty because we were in a special case where we won't enter the catch block. 2. My past observations are on this branch if anyone wants to refer: https://github.com/thesmallstar/fineract/tree/refer Note that, EmptyResultDataAccessException is thrown when more than one row is returned by the query. It is actually thrown when atleast one row is expected and zero received (I wrote it incorrectly in comments, Sorry for that) The explanation for the count (*) still remains the same. It is bound to return a single row 3. Use of Exception class is not yet done, it will be the very next checkstyle I work on. I have not done it here to collectively address them all in a single PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
