thesmallstar opened a new pull request #1037: URL: https://github.com/apache/fineract/pull/1037
Just curious on this change: IllegalThrows: Declaring that a method throws java.lang.Error or java.lang.RuntimeException is almost never acceptable. I was doing a bit of research why this is not a good idea, I came across a contradicting statement on this on [link](https://stackabuse.com/exception-handling-in-java-a-complete-guide-with-best-and-worst-practices/ ) : Since we're throwing a runtime exception, there's no need to include it in the method signature, like in the example above, but it's often considered good practice to do so, at least for the sake of documentation. Any comments on this @vorburger @xurror @ptuomola ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
