vorburger commented on pull request #1001: URL: https://github.com/apache/fineract/pull/1001#issuecomment-642903263
@rarkins may I provide you some RenovateBot feedback here? This PR is incorrect, because: Upgrading Gradle from 6.4 to 6.5 as per https://docs.gradle.org/6.5/release-notes.html using: ./gradlew wrapper --gradle-version=6.5 should also update `fineract-provider/gradle/wrapper/gradle-wrapper.jar`, `fineract-provider/gradlew`, and `fineract-provider/gradlew.bat` - and not just the `gradle-wrapper.properties` which so far is included. Perhaps that's something you'd like to fix? PS: In this case now, I don't think it's our `.gitignore`'s fault anymore like we had discussed in FINERACT-962, as #994 is long in, and while [this project's .gitnore](https://github.com/apache/fineract/blob/develop/.gitignore) still contains `.gradle`, the above mentioned files missing here aren't (shouldn't) be matched. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
