thesmallstar commented on a change in pull request #988:
URL: https://github.com/apache/fineract/pull/988#discussion_r439058566
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/loan/LoanImportHandler.java
##########
@@ -431,7 +431,7 @@ private Integer importDisbursalData(CommandProcessingResult
result, int rowIndex
String linkAccountId = disbusalData.getLinkAccountId();
GsonBuilder gsonBuilder = new GsonBuilder();
gsonBuilder.registerTypeAdapter(LocalDate.class, new
DateSerializer(dateFormat));
- if (linkAccountId != null && linkAccountId != "") {
+ if (linkAccountId != null && !"".equals(linkAccountId)) {
Review comment:
I am late again :(
@percyashu @vorburger I haven't seen "".equals being used before, should we
not use linkAccountId.isEmpty() instead? Although it seems they mean the same
thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
