xurror commented on a change in pull request #1024:
URL: https://github.com/apache/fineract/pull/1024#discussion_r439153425
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanArrearsAgingServiceImpl.java
##########
@@ -423,18 +423,14 @@ public OriginalScheduleExtractor(final String
loanIdsAsString) {
while (rs.next()) {
Long loanId = rs.getLong("loanId");
- List<LoanSchedulePeriodData> periodDatas = new ArrayList<>();
- LoanSchedulePeriodData loanSchedulePeriodData =
fetchLoanSchedulePeriodData(rs);
- periodDatas.add(loanSchedulePeriodData);
- while (rs.next()) {
- Long tempLoanId = rs.getLong("loanId");
- if (loanId.equals(tempLoanId)) {
Review comment:
I'm trying to understand this to the best I can but I just have the
feeling that this piece of logic is missing. Can you maybe make it a little
clearer for me?
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
