ptuomola opened a new pull request #1069:
URL: https://github.com/apache/fineract/pull/1069


   ## Description
   This PR includes:
   
   - Upgrading Swagger UI to the latest version (3.26.0)
   - Making Swagger UI a packaged dependency rather than checking in the 
individual files
   - Exposing Swagger UI in /fineract-provider/swagger-ui with response.json as 
the input
   - Adding Swagger Plugin to autogenerate the JSON spec
   - Configuring Gradle tasks to build the JSON spec automatically after build
   
   The Swagger UI does not yet point to the new JSON (fineract.json) but 
instead points to the previous manually created response.json, which remains 
checked in. The next step would be to ensure the autogenerated fineract.json 
contains all the same information as the response.json. After that, the 
response.json can be deleted. 
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [ ] Commit message starts with the issue number from 
https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at 
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have 
been followed.
   
   - [ ] API documentation at 
fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been 
updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes 
made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in 
repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at 
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to