vorburger commented on a change in pull request #1092:
URL: https://github.com/apache/fineract/pull/1092#discussion_r443112979
##########
File path: fineract-provider/build.gradle
##########
@@ -382,12 +381,10 @@ tasks.withType(JavaCompile) {
"ProtectedMembersInFinalClass",
"StaticAssignmentInConstructor",
"UnescapedEntity",
- "EmptyCatch",
Review comment:
Wait, what? No, this one I want... :smile: This is related to
FINERACT-942 and
https://checkstyle.sourceforge.io/config_blocks.html#EmptyCatchBlock
@thesmallstar we should be able to enforce this by moving to error, agreed?
##########
File path: fineract-provider/build.gradle
##########
@@ -444,13 +442,10 @@ tasks.withType(JavaCompile) {
"DoubleBraceInitialization",
"InconsistentCapitalization",
"MissingOverride",
-// "ReturnMissingNullable",
Review comment:
This https://errorprone.info/bugpattern/ReturnMissingNullable could
actually be nice, for NPE safety (which is something I was quite passionate
about, a while ago, see http://www.lastnpe.org) - but of course depends on the
effort... how many violations are there for this?
##########
File path: fineract-provider/build.gradle
##########
@@ -444,13 +442,10 @@ tasks.withType(JavaCompile) {
"DoubleBraceInitialization",
"InconsistentCapitalization",
"MissingOverride",
-// "ReturnMissingNullable",
// "InconsistentOverloads",
// "MethodCanBeStatic",
// "Var",
// "ConstantField",
-// "ConstructorInvokesOverridable",
Review comment:
see https://errorprone.info/bugpattern/ConstructorInvokesOverridable ..
how many of this are there, is this hard to fix? I think you may be able to
easily fix it just by making something methods that are called from
constructors `private` and/or `final`...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
