vorburger commented on pull request #1079: URL: https://github.com/apache/fineract/pull/1079#issuecomment-647013479
> I'll have a closer look at the build failure some time in the coming week, and propose how to So most of this seems to be related to Fineract's concept of having its own "business" exceptions (like `RoleNotFoundException` and all those other many subclasses of `AbstractPlatformResourceNotFoundException`), and their constructors not accepting any `Throwable cause` argument. If we do want to introduce this quality check (which I think we should, in order to prevent wrong exception handling for OTHER types of exception than those mentioned above), then I think the easiest way, and most "consistent", would be to simple have even those "business" exceptions accept a `cause` (unrelated to whether they really "need" it or not; I don't really see any "harm"). @ptuomola does this sound reasonable to you? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
