This is an automated email from the ASF dual-hosted git repository. vorburger pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git
commit 66c3bfdd4f5b16e50e2a606762773e2a8d22ec2f Author: percyashu <[email protected]> AuthorDate: Wed Jun 24 22:16:37 2020 +0100 FINERACT-822 Enforce PublicConstructorForAbstractClass check --- fineract-provider/build.gradle | 4 ++-- .../core/exception/AbstractPlatformDomainRuleException.java | 2 +- .../core/exception/AbstractPlatformServiceUnavailableException.java | 2 +- .../savings/service/DepositAccountReadPlatformServiceImpl.java | 4 ++-- .../savings/service/DepositProductReadPlatformServiceImpl.java | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/fineract-provider/build.gradle b/fineract-provider/build.gradle index fdfda28..3162976 100644 --- a/fineract-provider/build.gradle +++ b/fineract-provider/build.gradle @@ -215,7 +215,7 @@ jacocoTestReport{ spotless { format 'misc', { target '**/*.md', '**/*.properties', '**/*.gradle', '**/.gitignore', '**/*.yml', '**/*.xml', '**/**.json', '**/*.sql' - targetExclude '**/build/**', '**/bin/**', '**/.settings/**' + targetExclude '**/build/**', '**/bin/**', '**/.settings/**','**/.idea/**' indentWithSpaces(4) endWithNewline() trimTrailingWhitespace() @@ -391,7 +391,6 @@ tasks.withType(JavaCompile) { "InvalidParam", "ReturnFromVoid", "AlmostJavadoc", - "PublicConstructorForAbstractClass", "ProtectedMembersInFinalClass", "StaticAssignmentInConstructor", "UnescapedEntity", @@ -453,6 +452,7 @@ tasks.withType(JavaCompile) { "MissingCasesInEnumSwitch", "ReferenceEquality", "UndefinedEquals", + "PublicConstructorForAbstractClass", "OperatorPrecedence", "EqualsGetClass", "EqualsUnsafeCast", diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exception/AbstractPlatformDomainRuleException.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exception/AbstractPlatformDomainRuleException.java index 5d830ef..0499488 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exception/AbstractPlatformDomainRuleException.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exception/AbstractPlatformDomainRuleException.java @@ -27,7 +27,7 @@ public abstract class AbstractPlatformDomainRuleException extends RuntimeExcepti private final String defaultUserMessage; private final Object[] defaultUserMessageArgs; - public AbstractPlatformDomainRuleException(final String globalisationMessageCode, final String defaultUserMessage, + protected AbstractPlatformDomainRuleException(final String globalisationMessageCode, final String defaultUserMessage, final Object... defaultUserMessageArgs) { this.globalisationMessageCode = globalisationMessageCode; this.defaultUserMessage = defaultUserMessage; diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exception/AbstractPlatformServiceUnavailableException.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exception/AbstractPlatformServiceUnavailableException.java index cf905ec..bfdba2c 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exception/AbstractPlatformServiceUnavailableException.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exception/AbstractPlatformServiceUnavailableException.java @@ -27,7 +27,7 @@ public abstract class AbstractPlatformServiceUnavailableException extends Runtim private final String defaultUserMessage; private final Object[] defaultUserMessageArgs; - public AbstractPlatformServiceUnavailableException(final String globalisationMessageCode, final String defaultUserMessage, + protected AbstractPlatformServiceUnavailableException(final String globalisationMessageCode, final String defaultUserMessage, final Object... defaultUserMessageArgs) { this.globalisationMessageCode = globalisationMessageCode; this.defaultUserMessage = defaultUserMessage; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountReadPlatformServiceImpl.java index 5c1bc58..69b5864 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountReadPlatformServiceImpl.java @@ -547,7 +547,7 @@ public class DepositAccountReadPlatformServiceImpl implements DepositAccountRead @Override public abstract DepositAccountData mapRow(ResultSet rs, int rowNum) throws SQLException; - public DepositAccountMapper() { + protected DepositAccountMapper() { final StringBuilder selectFieldsSqlBuilder = new StringBuilder(400); selectFieldsSqlBuilder.append("sa.id as id, sa.account_no as accountNo, sa.external_id as externalId, "); selectFieldsSqlBuilder.append("c.id as clientId, c.display_name as clientName, "); @@ -1083,7 +1083,7 @@ public class DepositAccountReadPlatformServiceImpl implements DepositAccountRead private final ClientData client; private final GroupGeneralData group; - public DepositAccountTemplateMapper(final ClientData client, final GroupGeneralData group) { + protected DepositAccountTemplateMapper(final ClientData client, final GroupGeneralData group) { this.client = client; this.group = group; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositProductReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositProductReadPlatformServiceImpl.java index 7042bb3..f440463 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositProductReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositProductReadPlatformServiceImpl.java @@ -133,7 +133,7 @@ public class DepositProductReadPlatformServiceImpl implements DepositProductRead @Override public abstract DepositProductData mapRow(ResultSet rs, int rowNum) throws SQLException; - public DepositProductMapper() { + protected DepositProductMapper() { final StringBuilder sqlBuilder = new StringBuilder(400); sqlBuilder.append("sp.id as id, sp.name as name, sp.short_name as shortName, sp.description as description, "); sqlBuilder.append(
