vorburger commented on a change in pull request #1119:
URL: https://github.com/apache/fineract/pull/1119#discussion_r447233139
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/interoperation/data/ExtensionData.java
##########
@@ -23,13 +23,14 @@
import com.google.gson.JsonObject;
import java.util.Arrays;
+import java.util.List;
import javax.validation.constraints.NotNull;
import org.apache.fineract.infrastructure.core.data.DataValidatorBuilder;
import org.apache.fineract.infrastructure.core.serialization.FromJsonHelper;
public class ExtensionData {
- public static final String[] PARAMS = { PARAM_KEY, PARAM_VALUE };
+ public static final List<String> PARAMS =
List.copyOf(Arrays.asList(PARAM_KEY, PARAM_VALUE));
Review comment:
I'm not convinced this `copyOf()` is actually really needed here, but it
doesn't really matter that much (here in a `static final` constant), so fine
for me... not a reason to hold back merging this, if that's the only feedback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
