vorburger commented on a change in pull request #1079:
URL: https://github.com/apache/fineract/pull/1079#discussion_r447258248
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/exception/EmailConfigurationNotFoundException.java
##########
@@ -28,4 +29,9 @@
public EmailConfigurationNotFoundException(final String name) {
super("error.msg.email.configuration.name.not.found", "Email
configuration with name " + name + " does not exist", name);
Review comment:
@thesmallstar @xurror the real question is really more if there are any
(legitimate) remaining usages of the original constructor, without the cause.
It seems like this was only used in
`EmailConfigurationReadPlatformServiceImpl`, which was changed to use the new
constructor, right? Then I actually agree that it would have been nicer and
better to just add an additional parameter here... this isn't important enough
to justify not finally merging this, so I'll probably go ahead, but I'll leave
this open in case you'd like to clean this up in a new PR? (And perhaps in
other exceptions where a cause was added - if there is no usage without a
cause, it's better to simplify - and force future users to provide a cause.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
