thesmallstar commented on pull request #1123:
URL: https://github.com/apache/fineract/pull/1123#issuecomment-653762592
> 1. I don't know if this actually works (PreparedStatement), so will have
to trust you that you test that it really does.
-> Yes it works! I have tested it :)
> 2. The current implementation seems to assume that `setLimit()` & Co.
would only ever be called after `addCriteria()` - right? That's... not a good
idea. Imagine some dumb developer coming along in a few months, not knowing how
you implemented this internally (and correctly so, they should not have to). So
they do `new SQLBuilder().addOrderBy().addCriteria(...).getSQLTemplate()` - and
that would create invalid SQL - agreed?
->Agreed I am making the change.
> 3. `SQLBuidlerTest` must be extended to cover these new methods.
->Extending, I was waiting for the approach to be marked correct :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
