xurror commented on a change in pull request #1114:
URL: https://github.com/apache/fineract/pull/1114#discussion_r449835259
##########
File path: fineract-provider/dependencies.gradle
##########
@@ -30,7 +30,8 @@ dependencies {
//
implementation(
//'ch.vorburger.mariaDB4j:mariaDB4j:2.4.0',
-
+ 'org.springframework.boot:spring-boot-starter-security',
+
'org.springframework.security.oauth.boot:spring-security-oauth2-autoconfigure:2.1.6.RELEASE',
Review comment:
We are trying to avoid specifying version numbers here.
Set the dependency and the version number in build.gradle. That way this is
free of version numbers
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TwoFactorAuthenticationFilter.java
##########
@@ -113,7 +113,7 @@ public void doFilter(ServletRequest req, ServletResponse
res, FilterChain chain)
chain.doFilter(req, res);
}
- @SuppressWarnings("deprecation") // TODO FINERACT-1012
+ // FINERACT-1012
Review comment:
I think the deprecation suppression here is directly related to
FINERACT-1012. Unless this resolves them somehow, I think it should remain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
