vorburger commented on a change in pull request #1173:
URL: https://github.com/apache/fineract/pull/1173#discussion_r455365500
##########
File path: fineract-provider/config/checkstyle/checkstyle.xml
##########
@@ -46,6 +46,11 @@
<module name="TreeWalker">
+ <module name="ParameterName">
+ <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$|[a-z]"/>
Review comment:
@thesmallstar I was surprised that the RegExp change was required.. * is
zero or many (+ is "at least one"), are you 100% sure that this is required?
I'm just going to merge this anyway as-is, but perhaps you'd like to retry
after if this can't be changed back?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
