[GitHub] [fineract] vorburger commented on a change in pull request #1113: Need an option to filter provisioning entries by date, Fineract-462

[GitBox]

vorburger commented on a change in pull request #1113:
URL: https://github.com/apache/fineract/pull/1113#discussion_r459152987



##########
File path: 
fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/service/ProvisioningEntriesReadPlatformServiceImpl.java
##########
@@ -349,5 +349,37 @@ public String schema() {
         return 
this.loanProductProvisioningEntryDataPaginationHelper.fetchPage(this.jdbcTemplate,
 sqlCountRows, sqlBuilder.toString(),
                 whereClauseItemsitems, mapper);
     }
+    @Override
+       public Page<ProvisioningEntryData> 
retrieveAllProvisioningEntriesByDate(Integer offset, Integer limit,
+                       String filterDate) {
+               Date filterdate = null;
+               if (filterDate != null) {
+                       try {
+                               SimpleDateFormat format = new 
SimpleDateFormat("dd MMMM yyyy", Locale.ENGLISH);
+                               filterdate = format.parse(filterDate);
+                       } catch (ParseException e) {
+                               e.printStackTrace();

Review comment:
       NOK, please follow 
https://github.com/apache/fineract/#error-handling-guidelines (use 
`LOG.error("retrieveAllProvisioningEntriesByDate() bad filterDate: {}", 
filterDate, e);`)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org