ptuomola commented on pull request #1237: URL: https://github.com/apache/fineract/pull/1237#issuecomment-673945067
@thesmallstar Finally had some time to look at this! So the problem seems to be that in this one, the request body was annotated with @Parameter whereas in all the others it is annotated with @RequestBody. I found another one that is similarly broken: JournalEntriesApiResource.createGLJournalEntry(). So in my view we should make this consistent with the others - i.e. use RequestBody. I will raise a PR to fix - if you can review to see if it makes sense to you, and then I can merge it. Was there a JIRA ticket for this already? Thanks for looking into this! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
