ptuomola commented on a change in pull request #1284: URL: https://github.com/apache/fineract/pull/1284#discussion_r480711946
########## File path: .github/PULL_REQUEST_TEMPLATE.MD ########## @@ -1,19 +1,24 @@ ## Description -Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket + +Describe the changes made and why they were made. + +Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284). + ## Checklist + Please make sure these boxes are checked before submitting your pull request - thanks! -- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API. +- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests -- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. +- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsability to get a proposed PR to pass the build, not primarily the project's maintainers. Review comment: ```suggestion - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. ``` ########## File path: .github/PULL_REQUEST_TEMPLATE.MD ########## @@ -1,19 +1,24 @@ ## Description -Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket + +Describe the changes made and why they were made. + +Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284). + ## Checklist + Please make sure these boxes are checked before submitting your pull request - thanks! -- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API. +- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests -- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. +- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsability to get a proposed PR to pass the build, not primarily the project's maintainers. -- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes. +- [ ] Create/update unit or integration tests for verifying the changes made. -- [ ] Integration tests have been created/updated for verifying the changes made. +- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. -- [ ] All Integrations tests are passing with the new commits. +- [ ] Add required Swagger annotation and updated API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes Review comment: ```suggestion - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes ``` ########## File path: .github/PULL_REQUEST_TEMPLATE.MD ########## @@ -1,19 +1,24 @@ ## Description -Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket + +Describe the changes made and why they were made. + +Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284). + ## Checklist + Please make sure these boxes are checked before submitting your pull request - thanks! -- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API. +- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests -- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. +- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsability to get a proposed PR to pass the build, not primarily the project's maintainers. -- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes. +- [ ] Create/update unit or integration tests for verifying the changes made. -- [ ] Integration tests have been created/updated for verifying the changes made. +- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. Review comment: ```suggestion - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions. ``` ########## File path: .github/PULL_REQUEST_TEMPLATE.MD ########## @@ -1,19 +1,24 @@ ## Description -Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket + +Describe the changes made and why they were made. + +Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284). + ## Checklist + Please make sure these boxes are checked before submitting your pull request - thanks! -- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API. +- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests -- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. +- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsability to get a proposed PR to pass the build, not primarily the project's maintainers. -- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes. +- [ ] Create/update unit or integration tests for verifying the changes made. -- [ ] Integration tests have been created/updated for verifying the changes made. +- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. -- [ ] All Integrations tests are passing with the new commits. +- [ ] Add required Swagger annotation and updated API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes -- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.) +- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailling list for guidance, if required.) Review comment: ```suggestion - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
