ptuomola commented on a change in pull request #1264:
URL: https://github.com/apache/fineract/pull/1264#discussion_r481556077
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java
##########
@@ -150,6 +155,13 @@ public LoanTransaction makeRepayment(final Loan loan,
final CommandProcessingRes
final LocalDate transactionDate, final BigDecimal
transactionAmount, final PaymentDetail paymentDetail, final String noteText,
final String txnExternalId, final boolean isRecoveryRepayment,
boolean isAccountTransfer, HolidayDetailDTO holidayDetailDto,
Boolean isHolidayValidationDone, final boolean
isLoanToLoanTransfer) {
+
+ final List<ApiParameterError> dataValidationErrors = new ArrayList<>();
+ final DataValidatorBuilder baseDataValidator = new
DataValidatorBuilder(dataValidationErrors).resource("loan.transaction");
+ final GlobalConfigurationPropertyData configuration =
this.configurationReadPlatformService
+ .retrieveGlobalConfiguration("Enable-Loan-Overpayment");
Review comment:
To make the current behaviour default, would it not make sense to have a
configuration value that works the other way around - i.e. call it
"block-loan-overpayment", and if it is present & enabled then overpayments are
blocked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
