vorburger commented on pull request #1356: URL: https://github.com/apache/fineract/pull/1356#issuecomment-700169705
@tonic889 oh, this is a follow-up to #1306 re. FINERACT-1113.. now I get it. Do you mind if I asked if you would be willing to `git commit --amend` this and write the commit message as per https://github.com/apache/fineract/#pull-requests? Your commit is too long (break it upinto a shorter first line, then empty line, then explanation; see history) and doesn't correctly refer to the issue; when you refer to a JIRA issue on issues.apache.org, do use FINERACT-xxx. If you use #... then it's a GitHub Pull Request link. Thank You for contributing! We're excited to see this recent 2nd PR from you. I've noticed that [you were around in 2017 & 2018 as well](https://github.com/apache/fineract/pulls?q=is%3Apr+author%3Atonic889+is%3Aclosed). We hope to see more from you! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
