vincent-fuchs commented on a change in pull request #1365:
URL: https://github.com/apache/fineract/pull/1365#discussion_r499153664



##########
File path: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/common/BusinessEventNotificationConstants.java
##########
@@ -25,47 +25,55 @@
 
     public enum BusinessEvents {
 
-        LOAN_APPROVED("loan_approved"), LOAN_REJECTED("loan_reject"), 
LOAN_UNDO_APPROVAL("loan_undo_approval"), LOAN_UNDO_DISBURSAL(
-                "loan_undo_disbursal"), 
LOAN_UNDO_LASTDISBURSAL("loan_undo_lastdisbursal"), LOAN_UNDO_TRANSACTION(
-                        "loan_undo_transaction"), 
LOAN_ADJUST_TRANSACTION("loan_adjust_transaction"), LOAN_MAKE_REPAYMENT(
-                                "loan_repayment_transaction"), 
LOAN_WRITTEN_OFF("loan_writtenoff"), LOAN_UNDO_WRITTEN_OFF(
-                                        "loan_undo_writtenoff"), 
LOAN_DISBURSAL("loan_disbursal"), LOAN_WAIVE_INTEREST(
-                                                "loan_waive_interest"), 
LOAN_CLOSE("loan_close"), LOAN_CLOSE_AS_RESCHEDULE(
-                                                        
"loan_close_as_reschedule"), LOAN_ADD_CHARGE("loan_add_charge"), 
LOAN_UPDATE_CHARGE(
-                                                                
"loan_update_charge"), LOAN_WAIVE_CHARGE(
-                                                                        
"loan_waive_charge"), LOAN_DELETE_CHARGE(
-                                                                               
 "loan_delete_charge"), LOAN_CHARGE_PAYMENT(
-                                                                               
         "loan_charge_payment"), LOAN_INITIATE_TRANSFER(
-                                                                               
                 "loan_initiate_transfer"), LOAN_ACCEPT_TRANSFER(
-                                                                               
                         "loan_accept_transfer"), LOAN_WITHDRAW_TRANSFER(
-                                                                               
                                 "loan_withdraw_transfer"), 
LOAN_REJECT_TRANSFER(
-                                                                               
                                         "loan_reject_transfer"), 
LOAN_REASSIGN_OFFICER(
-                                                                               
                                                 "loan_reassign_officer"), 
LOAN_REMOVE_OFFICER(
-                                                                               
                                                         
"loan_remove_officer"), LOAN_APPLY_OVERDUE_CHARGE(
-                                                                               
                                                                 
"loan_apply_overdue_charge"), LOAN_INTEREST_RECALCULATION(
-                                                                               
                                                                         
"loan_interest_recalculation"), LOAN_REFUND(
-                                                                               
                                                                                
 "loan_refund"), LOAN_FORECLOSURE(
-                                                                               
                                                                                
         "loan_foreclosure"), LOAN_CREATE(
-                                                                               
                                                                                
                 "loan_create"), LOAN_PRODUCT_CREATE(
-                                                                               
                                                                                
                         "loan_product_create"), SAVINGS_ACTIVATE(
-                                                                               
                                                                                
                                 "savings_activated"), SAVINGS_REJECT(
-                                                                               
                                                                                
                                         "savings_reject"), 
SAVINGS_POST_INTEREST(
-                                                                               
                                                                                
                                                 "savings_post_interest"), 
SAVINGS_DEPOSIT(
-                                                                               
                                                                                
                                                         "savings_deposit"), 
SAVINGS_CLOSE(
-                                                                               
                                                                                
                                                                 
"savings_close"), SAVINGS_WITHDRAWAL(
-                                                                               
                                                                                
                                                                         
"savings_withdrawal"), SAVINGS_APPROVE(
-                                                                               
                                                                                
                                                                                
 "savings_approve"), SAVINGS_CREATE(
-                                                                               
                                                                                
                                                                                
         "savings_create"), CLIENTS_ACTIVATE(
-                                                                               
                                                                                
                                                                                
                 "clients_activate"), SHARE_ACCOUNT_CREATE(
-                                                                               
                                                                                
                                                                                
                         "share_account_create"), CLIENTS_REJECT(
-                                                                               
                                                                                
                                                                                
                                 "clients_reject"), CLIENTS_CREATE(
-                                                                               
                                                                                
                                                                                
                                         "clients_create"), CENTERS_CREATE(
-                                                                               
                                                                                
                                                                                
                                                 "centers_create"), 
GROUPS_CREATE(
-                                                                               
                                                                                
                                                                                
                                                         "groups_create"), 
SHARE_PRODUCT_DIVIDENDS_CREATE(
-                                                                               
                                                                                
                                                                                
                                                                 
"share_product_dividends_create"), FIXED_DEPOSIT_ACCOUNT_CREATE(
-                                                                               
                                                                                
                                                                                
                                                                         
"fixed_deposit_account_create"), SHARE_ACCOUNT_APPROVE(
-                                                                               
                                                                                
                                                                                
                                                                                
 "share_account_approve"), RECURRING_DEPOSIT_ACCOUNT_CREATE(
-                                                                               
                                                                                
                                                                                
                                                                                
         "recurring_deposit_account_create");
+        LOAN_APPROVED("loan_approved"), //

Review comment:
       I could do it, but without these, spotless will complain and try to 
reformat it. Is there another way to tell spotless that it should not reformat ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to