vorburger commented on pull request #1355: URL: https://github.com/apache/fineract/pull/1355#issuecomment-703264707
> I wasn't able to find any "stripped down" Flyway distribution when I looked Yeah, looks like they're not big on proper modularity, seeing https://github.com/flyway/flyway/blob/master/flyway-core/pom.xml. They do however use `<optional>true`, see https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html. Initially I suspected that Gradle simply doesn't dig `<optional>true` in Maven POMs, and glanced at https://blog.gradle.org/optional-dependencies and https://docs.gradle.org/current/userguide/feature_variants.html seem to be related to that. Then I noticed that `software.amazon.awssdk:s3` is the ONLY (of many) deps in Flyway that is NOT `<optional>true`. That does not seem right, to me. I'll raise a PR for Flyway to propose they make it optional in their next release. Others seem to have noticed that as well, note https://github.com/flyway/flyway/issues/2957. > but I agree excluding the AWS dependency is likely to work, so I can try that a bit later. Agreed, this seems like the best solution for the very short term, so I'm proposing that in #1367 (not yet tested). > At the same time, I do think moving to AWS SDK v2 would also be a sensible move - surely we would anyway want to use the latest version of the SDK... Separate, later? :smile: @ptuomola OK for you to close this PR, with follow-up in #1367? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
