vorburger commented on pull request #1381: URL: https://github.com/apache/fineract/pull/1381#issuecomment-706555171
@vidakovic thanks for letting me follow along the changes slowly and step by step! Sorry if this is a pain, and I'm learning more about what makes most sense in which order based on review feedback. So, to me personally, forcing people to re-import into an IDE is actually a non-issue, as long as we do everything in steps that everyone can easily understand. IMHO expecting re-import is totally fine; we can always send a line about it to the dev list if required, but I don't even think it really is.. you git pull, it's red, you git log, you figure it out. We can let others chime in on PR review dedicated to JUST that small change for that as well. So what would be the smallest possible incremental next step here then? Do you want to raise a separate new PR with JUST git mv the wrapper out of the fineract-provider into root, and whatever other minimal adjustments that requires, but only what's strictly required? (E.g. don't change bin to dev, yet; could be separate after.) I'm guessi ng that move, alone, wouldn't give us Spotless coverage for root files just yet, which is fine, we can get back to that in this PR, after. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
