vorburger commented on pull request #1387: URL: https://github.com/apache/fineract/pull/1387#issuecomment-706700824
> As far as I can see, what we need to achieve is to have the tagged 1.4.0 release commit (ee99f30) reachable from the develop branch - so that "git describe" and jgitver etc can "see" it in commit history of develop. Can I admit that I've only really fully understand now :smiling_imp: that that is the real reason for why you want to do this? I've played a bit with both `git describe` (and https://jgitver.github.io / https://github.com/jgitver/jgitver), and now see what you mean! I'll leave some related notes in FINERACT-1154. > As far as I can see, either approach will achieve that. Yeah, I think you're probably right - the order of the parents in a merge commit doesn't actually seem to really matter. > I agree with you that doing it "the other way" makes more sense - but as far as I can see, the outcome is the same regardless. OK, I've raised PR #1390 from my branch, where I have just updated the commit message, and we merge that one, just for clarity? Close this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
