vidakovic opened a new pull request #1416:
URL: https://github.com/apache/fineract/pull/1416


   ## Description
   
   This PR adds a new module to expose Fineract extension points:
   
   1. I've added an initial ReportingProcessService interface that is modelled 
after 
"fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/api/RunreportsApiResource.java";
 I removed all references to JAX-RS packages and classes, because I think we 
should not make any implementation detail assumptions and should try as much as 
possible to just rely on JDK runtime APIs
   2. above interface is not considered final; please chime in to discuss what 
we need to expose here
   3. as a consequence of Nr. 2 I have not integrated this in fineract-provider 
yet; probably this will be a breaking change for everything that is relying on 
Pentaho
   4. as soon as we settle on a reporting API we should create maybe a Github 
repo "mifos/fineract-contributions" where we could add a module that ports the 
Pentaho reporting stuff and makes it available as a JAR that Fineract users can 
include at runtime
   5. now that we have multiple Java modules I've moved all Gradle plugin 
configurations that are useful "up" to the root build.gradle file; that way we 
don't have to configure this multiple times and fineract-provider gets a lot 
leaner; these plugins are: Checkstyle, Jacoco, Errorprone, Spotbugs, Modernizer
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [x] Write the commit message as per 
https://github.com/apache/fineract/#pull-requests
   
   - [x] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   
   - [x] Create/update unit or integration tests for verifying the changes made.
   
   - [x] Follow coding conventions at 
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [x] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details 
of any API changes
   
   - [x] Submission is not a "code dump".  (Large changes can be made "in 
repository" via a branch.  Ask on the developer mailing list for guidance, if 
required.)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to