[fineract] branch develop updated: Add missing test coverage for Image 404 (FINERACT-1201)

[ptuomola]

This is an automated email from the ASF dual-hosted git repository.

ptuomola pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new d83bdc4  Add missing test coverage for Image 404 (FINERACT-1201)
d83bdc4 is described below

commit d83bdc41661ce3163231cf94d7a424da044c8b84
Author: Michael Vorburger <m...@vorburger.ch>
AuthorDate: Sun Oct 18 13:50:30 2020 +0200

    Add missing test coverage for Image 404 (FINERACT-1201)
---
 .../org/apache/fineract/integrationtests/StaffImageApiTest.java  | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git 
a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/StaffImageApiTest.java
 
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/StaffImageApiTest.java
index d54ee26..9e1bd0e 100644
--- 
a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/StaffImageApiTest.java
+++ 
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/StaffImageApiTest.java
@@ -36,6 +36,7 @@ public class StaffImageApiTest {
 
     private RequestSpecification requestSpec;
     private ResponseSpecification responseSpec;
+    private ResponseSpecification responseSpec404;
 
     @BeforeEach
     public void setup() {
@@ -43,6 +44,7 @@ public class StaffImageApiTest {
         this.requestSpec = new 
RequestSpecBuilder().setContentType(ContentType.JSON).build();
         this.requestSpec.header("Authorization", "Basic " + 
Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey());
         this.responseSpec = new 
ResponseSpecBuilder().expectStatusCode(200).build();
+        this.responseSpec404 = new 
ResponseSpecBuilder().expectStatusCode(404).build();
     }
 
     @Test
@@ -57,6 +59,7 @@ public class StaffImageApiTest {
         Integer staffId = StaffHelper.createStaff(this.requestSpec, 
this.responseSpec);
         Integer imageId = ImageHelper.createImageForStaff(this.requestSpec, 
this.responseSpec, staffId);
         assertNotNull(imageId, "Image id should not be null");
+
         String imageAsText = ImageHelper.getStaffImageAsText(this.requestSpec, 
this.responseSpec, staffId);
         assertNotNull("Image id should not be null", imageAsText);
         assertEquals(ImageHelper.generateImageAsText(), imageAsText);
@@ -67,6 +70,7 @@ public class StaffImageApiTest {
         Integer staffId = StaffHelper.createStaff(this.requestSpec, 
this.responseSpec);
         Integer imageId = ImageHelper.createImageForStaff(this.requestSpec, 
this.responseSpec, staffId);
         assertNotNull(imageId, "Image id should not be null");
+
         byte[] imageAsBytes = 
ImageHelper.getStaffImageAsBinary(this.requestSpec, this.responseSpec, staffId);
         assertNotNull(imageAsBytes, "Image content should not be null");
         assertEquals(251, imageAsBytes.length);
@@ -77,6 +81,7 @@ public class StaffImageApiTest {
         Integer staffId = StaffHelper.createStaff(this.requestSpec, 
this.responseSpec);
         Integer imageId = ImageHelper.createImageForStaff(this.requestSpec, 
this.responseSpec, staffId);
         assertNotNull(imageId, "Image id should not be null");
+
         imageId = ImageHelper.updateImageForStaff(this.requestSpec, 
this.responseSpec, staffId);
         assertNotNull(imageId, "Image id should not be null");
     }
@@ -86,7 +91,11 @@ public class StaffImageApiTest {
         Integer staffId = StaffHelper.createStaff(this.requestSpec, 
this.responseSpec);
         Integer imageId = ImageHelper.createImageForStaff(this.requestSpec, 
this.responseSpec, staffId);
         assertNotNull(imageId, "Image id should not be null");
+
         imageId = ImageHelper.deleteStaffImage(this.requestSpec, 
this.responseSpec, staffId);
         assertNotNull(imageId, "Image id should not be null");
+
+        ImageHelper.getStaffImageAsBinary(this.requestSpec, 
this.responseSpec404, staffId);
+        // No additional Assertion required, the point is the responseSpec404
     }
 }