vorburger commented on a change in pull request #1432:
URL: https://github.com/apache/fineract/pull/1432#discussion_r507612549
##########
File path:
fineract-client/src/main/java/org/apache/fineract/client/util/FineractClient.java
##########
@@ -26,7 +26,7 @@
*
* @author Michael Vorburger.ch
*/
-public class FineractClient {
+public final class FineractClient {
Review comment:
.. but this shouldn't be required? Especially since in #1433 I'm making
`createService()` a protected method, so this class should remain _open_
(extends-ible).
##########
File path:
fineract-client/src/main/java/org/apache/fineract/client/util/Calls.java
##########
@@ -27,7 +27,7 @@
*
* @author Michael Vorburger.ch
*/
-public class Calls {
+public final class Calls {
Review comment:
This makes sense, because it's a utility class with a private
constructor... (and I vaguely remember that we have a Checkstyle or ErrorProne
or SpotBugs check to enforce this - just want to find out why builds don't show
up as red - or where they do)
##########
File path:
fineract-client/src/main/java/org/apache/fineract/client/util/FineractClient.java
##########
@@ -42,7 +42,7 @@ public static FineractClientBuilder builder() {
return apiClient.createService(serviceClass);
}
- public static class FineractClientBuilder {
+ public static final class FineractClientBuilder {
Review comment:
as above (I think); best to see failing build and check if all 3 or only
1st (I think) need to be fixed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
