vorburger commented on pull request #1448:
URL: https://github.com/apache/fineract/pull/1448#issuecomment-712848727


   > Not sure if we can define this kind of thing in Checkstyle? I should have 
seen it yesterday, but my brain skipped the fact that we have that new JDK8 
compiler flag set in fineract-client. Maybe we set that flag in a different PR? 
Don't remember.
   
   Checkstyle can't catch this, but I would have expected #1446 to fail.. 
`sourceCompatibility = JavaVersion.VERSION_1_8` should not compile `var`? 
Something doesn't seem quite right if we didn't automatically catch this. 
Anyway.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to